"Douglas, William" <william.douglas(a)intel.com> writes:
On Tue, Feb 18, 2020 at 1:29 PM Leandro Dorileo
> For the legacy bios boot use cases clr-boot-manager will make sure to have the
> legacy bios bootable flag set, for that we're using sgdisk - making sgdisk a
> requirement to cbm.
This makes sense to me, though I think it is just a little odd since
normally this is an install task rather than cbm. cbm is tasked with
always being able to repair a given /boot to a working state. That
said I also think it is outside cbm's purview to do partition metadata
management so I could go either way on this change.
cbm will make sure to have the bios legacy boot flag set (when running on legacy
mode). When running on image mode (or when doing a fresh install) the bootloaders
backend implementation supporting legacy mode will try to ensure we have the flag
set, to do that these implementations (namely syslinux and extlinux) will rely on
sgdisk to set the mentioned flag.
We can get rid of this logic and change how the backends are implemented and add a
hard requirement for this case - setting the flag manually; and spreading this info
across the distro's documentation, or, we can leave it the way it is and add the
sgdisk to bootloader bundle.
>> Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo(a)intel.com>
>> bundles/bootloader | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git a/bundles/bootloader b/bundles/bootloader
>> index 1afb06aa..615de695 100644
>> --- a/bundles/bootloader
>> +++ b/bundles/bootloader
>> @@ -5,5 +5,6 @@
>> # [TAGS]: Tools and Utilities, Kernel
>> # [MAINTAINER]: Bernal Marin, Miguel