This is pretty okay code, it wouldn't be too much of an effort to
properly autotoolize it. Not saying that's really needed, since
William's last patches that were just merged are just fine, but having
the ability to run `make distcheck` is just a plus for any project.
If you're interested, let us know... it isn't as hard as it looks.
And thanks for pushing a tag/release, of course.
Auke
On 04/27/2018 01:32 PM, Douglas, William wrote:
Hi Jin Yao,
I just made a PR to numatop for some changes that would help up
package numatop. If you could review those before making a release (as
I needed them to autospec numatop on Clear Linux) that would be great.
As for the release itself, since you aren't using autotools creating a
make dist target is probably overkill. Instead you can just relay on
github to make a tar.gz of the commit you tag for the release and
Clear Linux can use that.
So for example:
https://github.com/clearlinux/clr-boot-manager/releases has a .tar.gz
file that github made when I created a release through their UI. Once
you have done that let me know and I'll be able to add numatop to
Clear Linux.
Thanks,
William
On Thu, Apr 26, 2018 at 6:58 PM, Jin, Yao <yao.jin(a)intel.com> wrote:
> Hi William,
>
> I'm maintaining the numatop. For making a release, do you mean I should provide a
tar package which only contains the source code and even with binary but it doesn't
need to be a full git repo, right?
>
> Once the release tar package is ready, I upload it to github and provide you a link.
Is this understanding correct?
>
> Thanks
> Jin Yao
>
> -----Original Message-----
> From: Douglas, William [mailto:william.douglas@intel.com]
> Sent: Friday, April 27, 2018 9:44 AM
> To: Du, Julie <julie.du(a)intel.com>
> Cc: dev(a)lists.clearlinux.org; Jin, Yao <yao.jin(a)intel.com>
> Subject: Re: [Clr-dev] Request to add NumaTOP to performance tool bundle
>
> Hi,
>
> As you are maintaining the tool would you mind making a release on github so that we
can use our automated tooling to track future releases so we can always keep numatop up to
date. Once you have a release tar I'll be happy to take a shot at packaging it.
>
> On Thu, Apr 26, 2018 at 6:38 PM, Du, Julie <julie.du(a)intel.com> wrote:
>> We have a tool named NumaTOP (
https://01.org/numatop ) . NumaTOP is an Intel
created observation tool for runtime memory locality characterization and analysis of
processes and threads running on a NUMA system. It helps the user to characterize the NUMA
behavior of processes and threads, and identify where the NUMA-related performance
bottlenecks reside. The open source code is:
https://github.com/intel/numatop . The tool
is integrated in Ubuntu since 16.04.
>>
>> Is it possible to add NumaTOP to the performance tool bundle in Clear Linux?
>>
>> Thanks
>> Julie
>>
>>
>> _______________________________________________
>> Dev mailing list
>> Dev(a)lists.clearlinux.org
>>
https://lists.clearlinux.org/mailman/listinfo/dev
_______________________________________________
Dev mailing list
Dev(a)lists.clearlinux.org
https://lists.clearlinux.org/mailman/listinfo/dev