Re: [Dev] bsdiff fork (and code in general)

Hi Tim, On Wed, Aug 26, 2015, at 08:05 PM, Tim Pepper wrote: Ok, I understand that. The thing that concerns me with bsdiff: 1) Backwards compatibility over time; we don't want changes in the code to cause older clients to be unable to interpret new versions 2) Are there any inputs for which bsdiff generates incorrect output? I don't know if this has happened, but it is a concern. This one I think can mostly be mitigated by re-applying the patch at build time and verifying it's identical. The cost of that would be small for the server. But it ties in with #1 - as the bsdiff code changes, all historical versions would need to be checked as well. The OSTree project maintainers have been contributing to: https://github.com/mendsley/bsdiff It would be quite nice if some effort was made to merge there; there's been some very similar changes made. Would you be open to having it be a standalone git repository at least? git submodules make having lots of tiny git repositories still ergonomic.